qnngroup / qnngds

MIT License
4 stars 3 forks source link

generate_api warnings #50

Closed reed-foster closed 6 months ago

reed-foster commented 6 months ago
Info: in module 'tests', function 'alignment_mark' was plotted
Info: in module 'tests', function 'resolution_test' was plotted
Info: in module 'tests', function 'vdp' was plotted
Info: in module 'circuits', function 'snspd_ntron' was plotted
Info: in module 'geometries', function 'hyper_taper' was plotted
Info: in module 'devices/resistor', function 'meander' was plotted
Info: in module 'devices/resistor', function 'sc_contacts' was plotted
Info: in module 'devices/nanowire', function 'spot' was plotted
Info: in module 'devices/ntron', function 'sharp' was plotted
Info: in module 'devices/ntron', function 'smooth' was plotted
Info: in module 'devices/ntron', function 'smooth_compassPorts' was plotted
Info: in module 'devices/snspd', function 'vertical' was plotted
Info: in module 'design', function 'create_chip' was plotted
Warning: in module 'design', function 'place_on_chip' was not plotted: place_on_chip() missing 4 required positional arguments: 'cell', 'coordinates', 'chip_map', and 'die_w'
Warning: in module 'design', function 'place_remaining_devices' was not plotted: place_remaining_devices() missing 3 required positional arguments: 'devices_to_place', 'chip_map', and 'die_w'
Info: in module 'cells', function 'alignment' was plotted
Info: in module 'cells', function 'etch_test' was plotted
Info: in module 'cells', function 'nanowires' was plotted
Info: in module 'cells', function 'ntron' was plotted
Info: in module 'cells', function 'resolution_test' was plotted
Info: in module 'cells', function 'snspd_ntron' was plotted
Info: in module 'cells', function 'vdp' was plotted
Warning: in module 'utilities', function 'add_hyptap_to_cell' was not plotted: add_hyptap_to_cell() missing 1 required positional argument: 'die_ports'
Info: in module 'utilities', function 'die_cell' was plotted
Warning: in module 'utilities', function 'route_to_dev' was not plotted: route_to_dev() missing 2 required positional arguments: 'ext_ports' and 'dev_ports'

It looks like some functions don't have default arguments. Looking at which functions it is, I'm guessing it's fine, but maybe we could look into fixing this at some point. Or not

reed-foster commented 6 months ago

52 I think this is satisfactory for now