qodesmith / datepicker

Get a date with JavaScript! A datepicker with no dependencies.
344 stars 101 forks source link

Datepicker SCSS variables #121

Open jt-adwisemedia opened 3 years ago

jt-adwisemedia commented 3 years ago

Hello!

This is more of a suggestion, having issues overriding your ./src/datepicker.scss.

  1. You should really put your variables in a ./src/variables.scss file and make sure that all variables have the !default "tag" after each variable.
  2. You should also make sure that all colors use variables instead of hardcoding "orange".

And yeah I can do do manual overrides and use !important, however...

  1. Using !important is generally a bad practise.
  2. It would result in double the amount of CSS, possibly even more if someone would need to use a more specific rule, and what I mean is that I would first have to include ./src/datepicker.scss and then I would have to also have to add add my own overwrites for the same rules that already exists in ./src/datepicker.scss, resulting in double or more CSS in the final dist file, also a bad practise.

Best regards, JT