search

qodesmith / datepicker

Get a date with JavaScript! A datepicker with no dependencies.
344 stars 101 forks source link

Saturday divs break to next line #82

Closed ikirkpat closed 4 years ago

ikirkpat commented 4 years ago

My saturday column wraps to the next line on MS Edge.

broken_saturday_column

I inspected and modified the cell width from width: calc(14.2857%) to width: calc(14%) and it worked fine so I'm sure it's something with the new line after each cell adding width but I'd obviously like to not have to modify the css of the cells to make it work.

qodesmith commented 4 years ago

What browser are you using?

qodesmith commented 4 years ago

Also, can you try using calc(100% / 7) and tell me if that works? In the SCSS that's what the calculation is, but apparently it's being rendered to a literal percent in the production css. Pretty sure browsers differ in how they calculate sub-pixel rendering. My hope is that if it stays a raw calc computation, the browser is left free to calculate accordingly instead of being forced to a specific percent.

qodesmith commented 4 years ago

@ikirkpat I'll need you to confirm before I merge this. Also, I downloaded Edge and couldn't reproduce this. Albeit, I'm on a Mac.

qodesmith commented 4 years ago

Ended up merging anyways.