search

qoherent / ria

Radio Intelligence Apps' open-source core, by Qoherent 📡🚀
https://www.qoherent.ai/radiointelligenceapps-project/
GNU Affero General Public License v3.0
6 stars 0 forks source link

BUG: `print_version_info()` doesn't work outside of ria directory #23

Open mrl280 opened 5 months ago

mrl280 commented 5 months ago

Description: print_version_info() only works if your current working directory is the 'ria' directory. If you are in a different git project, it will report the git hash of that project. If you are not in a git project, the helper function _get_commit_hash() will raise a RunTimeError.

Project Area: ria.diagnostics.print_version_info.py

Steps to Reproduce: Run ria version from the command line outside the ria project directory, or ria.print_version_info() from within a Python environment.

Expected Behavior: Report the git hash of the installed version of ria.

Actual Behavior: Report the git hash of the current working directory, If you are in the 'ria' directory, it works as expected, but otherwise it scrapes the wrong hash. Raises a RunTimeError if you are not in a git directory.

mrl280 commented 5 months ago

I removed the broken implementation in fdb097de44da95e1e39f024b3f4ae66120aec432. Additional work is needed to develop a new implementation.