search

qoire / bridge-operator-standard

Bridge Operator Standard for cross chain functionality between Aion & Ethereum blockchain
https://mavennet.com/bridge
MIT License
0 stars 0 forks source link

Exact meaning of _publicKey #2

Open qoire opened 5 years ago

qoire commented 5 years ago

https://github.com/qoire/bridge-operator-standard/blob/98b1409e8898d8e9c5da34aea9b9c9523468d939/contracts/Aion_BridgeOperatorBase_flat.sol#L274

Does this refer to the public key associated with the sk? Or the Aion address. Because this infers that the signatory is an address:

https://github.com/qoire/bridge-operator-standard/blob/98b1409e8898d8e9c5da34aea9b9c9523468d939/contracts/Aion_BridgeOperatorBase_flat.sol#L214-L226

Is there a reason for not just making signatories a bytes32 => bool mapping?

vaishnavipanchal23 commented 5 years ago

Q: Does this refer to the public key associated with the sk? Or the Aion address. Because this infers that the signatory is an address: It is the public key of the Aion account.

Q: Is there a reason for not just making signatories a bytes32 => bool mapping? The reason this is address => bool instead of bytes32 => bool is because we want to keep the contracts symmetric for Ethereum too.