qojulia / QuantumCumulants.jl

Generalized mean-field equations in open quantum systems
Other
70 stars 13 forks source link

Symbolicsv3 #216

Closed ChristophHotter closed 2 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.34483% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (8719ab5) to head (dc4509a). Report is 8 commits behind head on master.

Files Patch % Lines
src/index_average.jl 81.81% 6 Missing :warning:
src/index_meanfield.jl 76.92% 3 Missing :warning:
src/indexing.jl 72.72% 3 Missing :warning:
src/latexify_recipes.jl 0.00% 2 Missing :warning:
src/qnumber.jl 66.66% 2 Missing :warning:
src/index_double_sums.jl 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #216 +/- ## ========================================== - Coverage 78.63% 78.36% -0.28% ========================================== Files 26 26 Lines 5379 5389 +10 ========================================== - Hits 4230 4223 -7 - Misses 1149 1166 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-pl commented 3 weeks ago

@oameye this is finally a version that works with the new Symbolics versions. It directly bumps to v3 of SymbolicUtils. Is that an issue for you? Also, it would supersede your PR #212

oameye commented 3 weeks ago

@david-pl @ChristophHotter Thank you for completing this PR! I couldn't figure it out myself. I don't need compatibility with older versions. So you have my approval to merge :)

oameye commented 2 weeks ago

🎉 Thanks for pushing this!