search

qojulia / QuantumInterface.jl

Lightweight interface for Quantum Physics related packages
MIT License
6 stars 5 forks source link

Solve piracies and ambiguities #28

Closed Tortar closed 3 months ago

Tortar commented 3 months ago

Part of https://github.com/QuantumSavory/QuantumSavory.jl/pull/143

Tortar commented 3 months ago

Also this one should be it

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 17.29%. Comparing base (a3b09c2) to head (2b56209). Report is 4 commits behind head on main.

Files Patch % Lines
src/embed_permute.jl 0.00% 2 Missing :warning:
src/abstract_types.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== + Coverage 15.60% 17.29% +1.68% ========================================== Files 12 12 Lines 378 399 +21 ========================================== + Hits 59 69 +10 - Misses 319 330 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tortar commented 3 months ago

Now tests should pass on all versions, the compat missed some entries and Aqua complained. So this could be merged I think

Krastanov commented 3 months ago

apologies for the delay on responding here, I am running a summer workshop next week (qnumerics.org) and prep has taken some of my time. FYI, in case I do not finish reviewing this family of PRs this week, I might be in a bit of radio silence next week during the workshop

Tortar commented 3 months ago

No problem, I'm not in a rush to finish all of this, but this one should be relatively easy to review and merging it would allow be to test in CI the main one, so if you have some time for review for this one this it will make everything a bit faster

Krastanov commented 3 months ago

the QuantumSavory failure is due to the upstreaming, so it is to be expected