Move all abstract functionality from QuantumOpticsBase to QuantumInterface

Krastanov commented 1 year ago

fixes piracy issues
makes the distinctions between QuantumOpticsBase and QuantumInterface clearer
- QuantumInterface is for abstract types and concrete bases (so it can be used by QuantumSymbolics, QuantumClifford, and QuantumSavory)
- QuantumOpticsBase is for concrete datastructures for Schroedinger-style simulations
- QuantumOptics is for dynamics over types defined in QuantumOpticsBase

Surprisingly, this was very easy. There is only one difficult piracy issue to be fixed, a testament of how well abstracted the two layers of QuantumOpticsBase have been from before the split into QuantumInterface.

No new functionality is added. No functionality is removed. Almost all piracy issues are fixed. Significant new tests are added.

This is a breaking version -- 0.2.0. It will not be used by any other library until their compat field is updated.

I will wait a weak or so for review, but as there are no functionality changes, only moving code around, I will not block the merge waiting on review. Let me know if you prefer I take it slower. We can have slower more thorough merge window on the QuantumOpticsBase side of things.

fixes https://github.com/qojulia/QuantumInterface.jl/issues/4

codecov[bot] commented 1 year ago

Codecov Report

Merging #7 (8925573) into main (ba929de) will increase coverage by 17.64%. The diff coverage is 23.54%.

@@            Coverage Diff             @@
##            main       #7       +/-   ##
==========================================
+ Coverage   0.00%   17.64%   +17.64%     
==========================================
  Files          2       12       +10     
  Lines         99      391      +292     
==========================================
+ Hits           0       69       +69     
- Misses        99      322      +223

Impacted Files	Coverage Δ
src/abstract_types.jl	`0.00% <0.00%> (ø)`
src/bases.jl	`0.00% <0.00%> (ø)`
src/embed_permute.jl	`0.00% <0.00%> (ø)`
src/expect_variance.jl	`0.00% <0.00%> (ø)`
src/identityoperator.jl	`0.00% <0.00%> (ø)`
src/julia_base.jl	`0.00% <0.00%> (ø)`
src/julia_linalg.jl	`0.00% <0.00%> (ø)`
src/linalg.jl	`0.00% <0.00%> (ø)`
src/sparse.jl	`0.00% <0.00%> (ø)`
src/tensor.jl	`0.00% <0.00%> (ø)`
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Krastanov commented 1 year ago

I tried to make each commit easy to review on its own, if that is your preference. I would suggest merging without squashing. The "Breakage CI" is expected to fail as this is indeed a breaking release.

Krastanov commented 1 year ago

JET and lazy strings issues to be fixed shortly

Krastanov commented 1 year ago

it should be ready for review now

qojulia / QuantumInterface.jl

Move all abstract functionality from QuantumOpticsBase to QuantumInterface #7

Codecov Report