qojulia / QuantumOptics.jl-benchmarks

Benchmarks for popular Quantum Optics frameworks
http://qojulia.org
12 stars 6 forks source link

Incorrect benchmark for dense operator addition in Python #3

Closed akhmerov closed 3 years ago

akhmerov commented 3 years ago

Contrary to the description, the file below tests the timing of addition of two sparse matrices and not dense ones.

https://github.com/qojulia/QuantumOptics.jl-benchmarks/blob/master/benchmarks-QuTiP/addition_dense_dense.py

akhmerov commented 3 years ago

Same applies to dense multiplication—the Python version isn't dense.

david-pl commented 3 years ago

That is quite the copy-paste error you found there, thanks. I changed the code where necessary.