sd109 commented 3 years ago

Significantly improves both efficiency and readability of Bloch-Redfield tensor implementation. Also utilizes multi-threading when julia session is running with more than one thread available. I'd say this probably closes #270 too.

sd109 commented 3 years ago

I've just noticed the new PR #306 which also makes some changes to the bloch_redfield_tensor function. None of the changes look like they conflict with each other, but will need to double check before merging this.

codecov[bot] commented 3 years ago

Codecov Report

Merging #307 (3ad9fde) into master (3871335) will decrease coverage by 0.10%. The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   98.08%   97.98%   -0.11%     
==========================================
  Files          15       15              
  Lines        1305     1288      -17     
==========================================
- Hits         1280     1262      -18     
- Misses         25       26       +1

Impacted Files	Coverage Δ
src/bloch_redfield_master.jl	`93.42% <84.84%> (-2.28%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3871335...3ad9fde. Read the comment docs.

david-pl commented 3 years ago

@sd109 Thanks for this! The changes look good to me. Is this ready to merge from your side? I will adapt #306 to handle conflicts.

sd109 commented 3 years ago

Yeah this is ready to merge as far as I'm concerned.

qojulia / QuantumOptics.jl

Simpler bloch redfield tensor #307

Codecov Report