qojulia / QuantumOptics.jl

Library for the numerical simulation of closed as well as open quantum systems.
http://qojulia.org
Other
531 stars 104 forks source link

Support time-dependent operators in timeevolution #366

Closed amilsted closed 1 year ago

amilsted commented 1 year ago

This accompanies https://github.com/qojulia/QuantumOpticsBase.jl/pull/104. Tests won't pass until those changes are included.

Provides methods for "dynamic" time evolution that take time-dependent operators directly.

Krastanov commented 1 year ago

@mabuni1998 , similarly to my comment on https://github.com/qojulia/QuantumOpticsBase.jl/pull/104 , this is something that will probably be of interest to you in the context of WaveguideQED.jl

Krastanov commented 1 year ago

Any chance you have the bandwidth to mention these in the documentation? Either way, we should probably create an issue about the need for more extensive documentation and examples using these new types of operators.

amilsted commented 1 year ago

Any chance you have the bandwidth to mention these in the documentation? Either way, we should probably create an issue about the need for more extensive documentation and examples using these new types of operators.

Yeah, docs are lagging a bit in general. Should provide some examples or tutorials for this too. I can add some minimal documentation and a simple example for now.

codecov[bot] commented 1 year ago

Codecov Report

Merging #366 (561939b) into master (9284519) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   98.05%   98.11%   +0.06%     
==========================================
  Files          17       18       +1     
  Lines        1442     1488      +46     
==========================================
+ Hits         1414     1460      +46     
  Misses         28       28              
Impacted Files Coverage Δ
src/QuantumOptics.jl 100.00% <ø> (ø)
src/master.jl 100.00% <100.00%> (ø)
src/mcwf.jl 100.00% <100.00%> (ø)
src/schroedinger.jl 94.00% <100.00%> (+0.25%) :arrow_up:
src/time_dependent_operators.jl 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

amilsted commented 1 year ago

@Krastanov I have docs and examples PRs ready to go also (although I don't know how to deploy the main docs!). I think this is ready from my perspective.

Krastanov commented 1 year ago

LGTM