qojulia / QuantumOptics.jl

Library for the numerical simulation of closed as well as open quantum systems.
http://qojulia.org
Other
518 stars 101 forks source link

Promote TimeDependentSum to Dual when using ForwardDiff #378

Closed AmitRotem closed 6 months ago

AmitRotem commented 6 months ago

Issue https://github.com/qojulia/QuantumOptics.jl/issues/376

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8012aa8) 97.80% compared to head (52e0dc7) 97.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #378 +/- ## ======================================= Coverage 97.80% 97.81% ======================================= Files 18 18 Lines 1550 1554 +4 ======================================= + Hits 1516 1520 +4 Misses 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amilsted commented 6 months ago

Thanks @AmitRotem! Looks good. Btw, do we support ForwardDiff for the other evolution methods yet?

AmitRotem commented 6 months ago

As far as I know only for schroedinger. In the past we've opened an issue for that; https://github.com/qojulia/QuantumOptics.jl/issues/357