Open Krastanov opened 1 year ago
This is fixed in https://github.com/qojulia/QuantumOpticsBase.jl/pull/110, but there are still things that can be improved. Namely, the large block of methods with a TODO left in it can be improved by leaning a bit harder into using FillArray and lazy embeds, for scaled identities and for tensor products with identities. Leaving open but renaming
Noting here that FillArrays 1.3 improves on this: https://github.com/JuliaArrays/FillArrays.jl/issues/265
kron is fixed upstream, but addition still gives us dense.
Since 0.4 we have
Eye+sparse=dense
. We should keep the sparsity in situations like this.Regression reported over slack by Satya Bade: