qojulia / QuantumOpticsBase.jl

Base functionality library for QuantumOptics.jl
Other
64 stars 34 forks source link

CompatHelper: bump compat for FastGaussQuadrature to 1, (keep existing compat) #148

Closed github-actions[bot] closed 10 months ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the FastGaussQuadrature package from 0.5 to 0.5, 1. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 1 year ago

Codecov Report

Merging #148 (bcfe9c5) into master (d2e4c8e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files          24       24           
  Lines        3018     3018           
=======================================
  Hits         2818     2818           
  Misses        200      200           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Krastanov commented 10 months ago

https://github.com/JuliaApproximation/FastGaussQuadrature.jl/issues/128 seems to imply this version bump only included deprecations, nothing actually breaking. FastGaussQuadrature does not seem to follow semver too closely, so we might end up with a break when they update to 1.1