search

qojulia / QuantumOpticsBase.jl

Base functionality library for QuantumOptics.jl
Other
64 stars 34 forks source link

CompatHelper: bump compat for Adapt to 4, (keep existing compat) #151

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 10 months ago

This pull request changes the compat entry for the Adapt package from 1, 2, 3.3 to 1, 2, 3.3, 4. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

Krastanov commented 6 months ago

we should probably set up some GPU tests as well for this. The julia GPU team provide some runners for this

Krastanov commented 4 months ago

looking at the release notes for Adapt 4 and at our own code, nothing seems to have changed for us. I will proceed with merging this. I will make an issue to track the need for GPU CI tests.

Krastanov commented 4 months ago

oh, this was already done by #161 anyway