qojulia / QuantumOpticsBase.jl

Base functionality library for QuantumOptics.jl
Other
64 stars 34 forks source link

Add a dispatch on dagger for Eye to keep sparsity #153

Closed david-pl closed 8 months ago

david-pl commented 8 months ago

@Krastanov this should fix the test failures in #152.

FYI, @amilsted & @SatyaBade12 I had to add another method here, otherwise tests fail on Julia v1.10

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5ad7158) 93.37% compared to head (d7c1468) 93.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #153 +/- ## ========================================== - Coverage 93.37% 93.34% -0.04% ========================================== Files 24 24 Lines 3018 3019 +1 ========================================== Hits 2818 2818 - Misses 200 201 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

david-pl commented 8 months ago

Not sure about the CI failures on 1.6 now (they also seem to be caused by Eye), but I'm gonna go ahead and merge this to fix the builds.