search

qojulia / QuantumOpticsBase.jl

Base functionality library for QuantumOptics.jl
Other
64 stars 34 forks source link

Import coherentstate, thermalstate, displace, squeeze, wigner from QuantumInterface #175

Open Krastanov opened 2 months ago

Krastanov commented 2 months ago

Now that https://github.com/qojulia/QuantumInterface.jl/pull/29 is merged, it would make sense to rely on that namespace for these helper functions.

Krastanov commented 2 months ago

ping @apkille

apkille commented 1 month ago

@krastanov we get type piracy doing this, as the first four functions you mentioned dispatch on FockBasis, which is defined in QuantumInterface rather than QuantumOpticsBase. I missed this because FockBasis is not imported in the root file of QOBase and I was quick to assume it was defined somewhere in the package. Any ideas for fixing this?