qonto / prometheus-rds-exporter

Prometheus exporter for AWS RDS

MIT License

69 stars 11 forks source link

Add Checkcov in CI #111

Closed vmercierfr closed 9 months ago

vmercierfr commented 9 months ago

Objective

Add checkcov in CI

Why

Checkcov will help us to detect misconfigurations before they're deployed.

How

Add checkcov in CI
Add checkcov command in the makefile
Fix missing Docker HEALTHCHECK
Fix container running in root by using restricted sudo
Ignore CKV_AWS_356 because it raise false positive alerts

Release plan

[ ] Merge this PR
[ ] Apply with CI

github-advanced-security[bot] commented 9 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

vmercierfr commented 9 months ago

sre

github-actions[bot] commented 9 months ago

Package	Line Rate	Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch	88%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/ec2	88%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/exporter	80%	✔
github.com/qonto/prometheus-rds-exporter/internal/app/rds	80%	➖
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas	51%	❌
github.com/qonto/prometheus-rds-exporter/internal/app/unit	100%	✔
Summary	81% (939 / 1157)	✔

Minimum allowed line rate is 60%