search

qonto / prometheus-rds-exporter

Prometheus exporter for AWS RDS
MIT License
69 stars 12 forks source link

Consider unapplied parameter groups as pending modified values #23

Closed vmercierfr closed 1 year ago

vmercierfr commented 1 year ago

Objective

Consider unapplied parameter groups as pending modified values

Why

An RDS instance should be considered as "pending modified values" when instance modifications are pending (current behavior) but also when parameter groups are unapplied.

It's common to see RDS instances running with pending parameter group in "pending-reboot" status. It's tricky to detect it from AWS RDS console because this information is only displayed in the configuration tab of each RDS instance.

Example No maintenance on RDS instances list ![list](https://github.com/qonto/prometheus-rds-exporter/assets/319005/1f5b634f-82ac-4288-8800-c5ebd0c34150) Parameter group are not applied ![details](https://github.com/qonto/prometheus-rds-exporter/assets/319005/8a1045ff-9797-47a3-837d-50e545711a11)

How

Release plan

vmercierfr commented 1 year ago

sre

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch 88% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/ec2 88% ✔
github.com/qonto/prometheus-rds-exporter/internal/app/rds 78% ➖
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas 51% ❌
github.com/qonto/prometheus-rds-exporter/internal/app/unit 100% ✔
Summary 81% (511 / 628) ✔

Minimum allowed line rate is 60%