qontu / ngx-inline-editor

Native UI Inline-editor Angular (4.0+) component
https://qontu.github.io/ngx-inline-editor
MIT License
164 stars 90 forks source link

Add Support for Angular 6 & RxJS 6 #136

Open yehia2amer opened 6 years ago

yehia2amer commented 6 years ago

Now when trying to update to Angular 6 & RxJS 6, I got this error: node_modules/@qontu/ngx-inline-editor/inputs/input-base.d.ts(3,10): error TS2305: Module '"node_modules/rxjs/Subscription"' has no exported member 'Subscription'.

Any Plans to Update ?

Thanks!

rabin-naga commented 6 years ago

I am getting following error when using Inline Editor in Angular6.

ERROR Error: StaticInjectorError(AppModule)[NgClass -> ElementRef]: StaticInjectorError(Platform: core)[NgClass -> ElementRef]: NullInjectorError: No provider for ElementRef!

Any help? Thanks

KeithGillette commented 6 years ago

We are using @qontu/ngx-inline-editor@0.2.0-alpha.12 in an Angular 6.1.2 project with no issues except when we attempt to build with AoT per #127.

andys8 commented 6 years ago

Installing "rxjs-compat": "^6.0.0" resolved (at least removes) the error, but it's not working for me afterwards. Getting Can't bind to 'ngModel' since it isn't a known property of 'inline-editor'. but could also be me using it in a wrong way. But I'm trying the minimal example.