search

qontu / ngx-inline-editor

Native UI Inline-editor Angular (4.0+) component
https://qontu.github.io/ngx-inline-editor
MIT License
164 stars 90 forks source link

typings: not found #16

Closed ellipizle closed 7 years ago

ellipizle commented 8 years ago

This module keeps on failing on my build system with the following errors 10:08:24.279 npm ERR! Failed at the ng2-inline-editor@0.1.1-alpha.8 postinstall script 'typings install'.

BartNetJS commented 8 years ago

adding typings.json to the root of the solution fixed it in my case

Caballerog commented 8 years ago

@Ellipizle you willl need to install typings as global first.

npm install typings -g

It should probably be documented or automatically installed when you first run npm install, any ideas?

igncp commented 8 years ago

I think the issue could be in that the typings package is currently a devDependency and not a dependency, so it is not installed when a user includes ng2-inline-editor as a dependency.

I would guess that if it is moved to dependencies, when running typings install, first it would look in ./node_modules/.bin/typings (relative to the ng2-inline-editor dir).

To try it, a version with typings as a dependency would have to be published to npm and then installed in an environment without typings in the global packages.