search

qoobaa / s3

Library for accessing S3 objects and buckets, supports EU and US buckets
MIT License
258 stars 112 forks source link

Private by default #100

Closed icambron closed 9 years ago

icambron commented 9 years ago

That S3 uploads default to public isn't good. You should default to saving things privately and let the user make it public if they wish. If the user means for something to be public but doesn't know to do that, they'll soon find out. If they mean to keep it private but don't know to do that, they'll expose potentially sensitive data to the whole internet.

Would you accept a PR that changes that?

exadeci commented 9 years ago

+1

Name Description
x-amz-acl The canned ACL to apply to the object. For more information, go to Canned ACL in the Amazon Simple
Type: StringValid
Values: private		 public-read public-read-write authenticated-read bucket-owner-read bucket-owner-full-control
Default: private
qoobaa commented 9 years ago

Could you create a PR for that?

icambron commented 9 years ago

Totally can, just wanted to make sure it's a functionality change you'd accept first.

qoobaa commented 9 years ago

Sure, we can change it I think.

icambron commented 9 years ago

This was fixed by #106, so closing.