search

qoobaa / s3

Library for accessing S3 objects and buckets, supports EU and US buckets
MIT License
258 stars 112 forks source link

Minor error #101

Open exadeci opened 9 years ago

exadeci commented 9 years ago

https://github.com/qoobaa/s3/blob/386361c1b0ede19cde0ddaf86e41a16308575f5d/lib/s3/connection.rb#L67

Should be:

    if params.present?
      params = params.is_a?(String) ? params : self.class.parse_params(params)
      path << "?#{params}"
    end

Because it adds a "?" on every request.

arthurnn commented 9 years ago

fell free to open a PR, with a regression test to illustrate the bug.