search

qoobaa / s3

Library for accessing S3 objects and buckets, supports EU and US buckets
MIT License
258 stars 112 forks source link

None private acl by default #113

Closed maccman closed 7 years ago

maccman commented 8 years ago

The Readme states that "Please note that new objects are created with “private” ACL by default."

As far as I can see, that's not true? By default objects have a Everyone => Read ACL.

qoobaa commented 8 years ago

I think it's private by default: https://github.com/qoobaa/s3/blob/master/lib/s3/object.rb#L159

maccman commented 8 years ago

Hmm, I definitely had to set .acl = :private to get it private

qoobaa commented 8 years ago

I've just released the latest code, could you check it again please?

rishijain commented 8 years ago

@qoobaa I have checked with the latest version and by default it uploads as private. I think it would be a good idea to put this into documentation on how to set the acl of any new object. I have it in here https://github.com/qoobaa/s3/pull/114