search

qoobaa / s3

Library for accessing S3 objects and buckets, supports EU and US buckets
MIT License
258 stars 112 forks source link

Enhance Temporary URL Generation #18

Closed bbrowning closed 14 years ago

bbrowning commented 14 years ago

Jakub,

S3::Signature already has support for generating temporary url signatures. This commit enhances that existing functionality in two ways:

1) A new method, generate_temporary_url, to generate entire temporary urls instead of just their signatures.

2) Support for HTTP verbs besides GET and support for HTTP headers for the generated temporary url. This is useful if you'd like to generate a temporary URL to give to someone for uploading a file into your S3 bucket without having to make your bucket world-writable or give them your AWS credentials.

We're using a fork of your gem in the SteamCannon project (http://steamcannon.org) and it would be great to get this change pushed back upstream.

Thanks, Ben

qoobaa commented 14 years ago

Thanks for the patch!

I hope I'll merge it in the weekend. There're several other problems in the gem, like no streaming support, etc. I've created the gem for my previous project, but now I don't use it in the current one. If you have some other improvements or ideas it'd be simpler when I add you to the project collaborators. Let me know if you have some other stuff.

Cheers, Kuba.

bbrowning commented 14 years ago

I'm sure there will be a few more enhancements I'd like to make. I have another change I've already pushed to my branch allowing additional headers to be passed to the request on bucket creation, for setting things like the acl of the bucket.

If you're willing to add me as a collaborator, I'd be willing to commit these and other enhancements as I find them.

qoobaa commented 14 years ago

Merged.