search

qoobaa / s3

Library for accessing S3 objects and buckets, supports EU and US buckets
MIT License
258 stars 112 forks source link

Implement s3_force_path_style #94

Closed exadeci closed 9 years ago

exadeci commented 9 years ago

I'm on a pretty specific S3 and there seems to be a missing option on this gem the s3_force_path_style: true (https://github.com/aws/aws-sdk-ruby/blob/91700223be98d1e12f63a24ff260c021ebb8f0cb/lib/aws/core/configuration.rb#L132-L134)

Or did I missed it ?

qoobaa commented 9 years ago

It may be missing.

exadeci commented 9 years ago

Returning false with the vhost? method in bucket seems to make it work. I'll make a PR if I get the time to implement a cleaner way to do it.

arthurnn commented 9 years ago

@exadeci send the PR, and I will review it. thanks

exadeci commented 9 years ago

Here it's: https://github.com/qoobaa/s3/pull/98