qoocku / ac-sly

Emacs auto-complete source for SLY's Common Lisp IDE
10 stars 3 forks source link

Incompatible with Sly's recent completion system rewrite #4

Open mfiano opened 8 years ago

mfiano commented 8 years ago

It would be nice if this was compatible with a recent version of Sly.

joaotavora commented 8 years ago

I'll have a look

joaotavora commented 8 years ago

I've tried it and it seems to work OK for simple completions. For fuzzy/flex completions, can you try

(defalias 'sly-fuzzy-completions 'sly-flex-completions)

In your config temporarily? On a related, but different note, see also https://github.com/capitaomorte/sly/issues/83 for another possible upgrade pitfall...

mfiano commented 8 years ago

When i do that i get:

let: Wrong type argument: listp, #("decf" 0 2 (face completions-first-difference sly--annotation "-f---m--") 2 3 (sly--annotation "-f---m--") 3 4 (face completions-first-difference sly--annotation "-f---m--"))
Error running timer `ac-update-greedy': (wrong-type-argument listp #("decf" 0 2 (face completions-first-difference sly--annotation "-f---m--") 2 3 (sly--annotation "-f---m--") 3 4 (face completions-first-difference sly--annotation "-f---m--"))) [2 times]
joaotavora commented 8 years ago

Seen it. I'm working on a fix in SLY

joaotavora commented 8 years ago

Here's a complimentary screenshot screen shot 2016-04-01 at 18 07 11

mfiano commented 8 years ago

Nice, how did you get the documentation to the right of it? I've never seen that

joaotavora commented 8 years ago

All defaults and most recent versions of everything.

I started emacs with:

emacs -Q -L path-to-sly -L path-to-auto-complete -L path-to-ac-sly -L path-to-popup-el -l path-to-sly/sly-autoloads.el -l path-to-ac-sly/ac-sly.el -e sly

Then after SLY starts, M-x sly-scratch, then C-u M-x set-up-ac-sly, then M-x auto-complete-mode, then it should start working.

mfiano commented 8 years ago

I did that and only see the completion candidates - no documentation. Using latest packages from MELPA and emacs 24.5. No worries. Thanks for the quick fix!

mfiano commented 8 years ago

@capitaomorte This is not completely fixed. I can reproduce an error:

In REPL, type: (defun-fail-test)

Then press TAB to complete, and you get: Please install fuzzy.el if you use fuzzy completion

Then backspace so it reads: (def), and press TAB to complete and you get: Wrong number of arguments: (0 . 0), 1

You then have to clear the line completely to not receive this error, when initially there were no matches.

joaotavora commented 8 years ago

I cannot read your markdown description very well. What exactly do I type in the REPL?

mfiano commented 8 years ago

(defun-fail-test)

EDIT: or anything at all that has no matches, but there is a common piece with matches, such as "def" above.

mfiano commented 8 years ago

Have you been able to reproduce this?

joaotavora commented 8 years ago

Around the time you reported it, no I didn't, but I will try again later today. Sorry for not having said anything then by the way.

In the meantime, can you fully describe your setup (OS, emacs version, sly version, etc?). Can you reproduce it starting from Emacs -Q

On Mon, Jun 6, 2016 at 5:59 AM, axion notifications@github.com wrote:

Have you been able to reproduce this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/qoocku/ac-sly/issues/4#issuecomment-223869033, or mute the thread https://github.com/notifications/unsubscribe/AAXnw5ApnQ5W0TphC1m6cDdQsBmQCPXPks5qI6lHgaJpZM4H9zty .

João Távora

mfiano commented 8 years ago

Hmm, well it's not sly or ac-sly. I tried it with:

emacs -Q -L path-to-sly -L path-to-auto-complete -L path-to-ac-sly -L path-to-popup-el -l path-to-sly/sly-autoloads.el -l path-to-ac-sly/ac-sly.el -e sly

And the issue does not occur.