search

qoomon / aws-s3-bucket-browser

Single page application to browse AWS S3 bucket content
https://qoomon.github.io/aws-s3-bucket-browser/index.html?bucket=https://s3.amazonaws.com/spacenet-dataset#
MIT License
246 stars 85 forks source link

when in click in index.html inside a subfolder the file is downloaded instead of just serving it #1

Closed alin-simionoiuDE closed 4 years ago

alin-simionoiuDE commented 4 years ago

first of all: awesome job, love what you have done here.

the way i use it is to show a list of folder where each folder have various reports from a build process (karma tests, junit, coverage..etc). navigation in and out is great, no problems there

everything works great until i get inside one of the leaf folder that has the html report

here's one example so you can see what i'm talking about

Screen Shot 2019-11-26 at 6 21 26 PM

when i click on index.html the file is downloaded...but..if i right click, copy the link and paste that into a different tab the file is served and i can see the rendered html.

i'm purely guessing this is a content type problem...any ideas how to fix it?

qoomon commented 4 years ago

It is by purpose but maybe you are right and I should change it, or add a button to open the file or a dedicated button to download it. Currently I am on vacation so please create a pull request or wait until mid of December then I can fix it on my own.

qoomon commented 4 years ago

Try to remove line 107 and 158 of index.html

alin-simionoiuDE commented 4 years ago

awesome!!...that worked.

another one if you don't mind: is it possible to automatically sort by "Name" descendent?

qoomon commented 4 years ago

Just click the name column twice