search

qoomon / aws-s3-bucket-browser

Single page application to browse AWS S3 bucket content
https://qoomon.github.io/aws-s3-bucket-browser/index.html?bucket=https://s3.amazonaws.com/spacenet-dataset#
MIT License
246 stars 85 forks source link

Files containing a "+" in their name are not linked properly #32

Closed fvieillard closed 2 years ago

fvieillard commented 2 years ago

Hello @qoomon First, thanks for the great script !

I've found a small issue when one of the listed files contains a "+" in the name. When that happens, the download link will contain the "+" without escaping, which produces a 404 error if one clicks on the file.
If I replace the "+" with a "%2B", then the download link works.

So I guess it just lacks some logic to escape special characters in filenames to make it work in all cases.

Thanks !

qoomon commented 2 years ago

Thanks for reporting, I'll fix it.

qoomon commented 2 years ago

should work in version 1.8.3

fvieillard commented 2 years ago

Yes, it works fine now :)

Thanks a lot for the super quick fix !