qoomon / aws-s3-bucket-browser

Single page application to browse AWS S3 bucket content
https://qoomon.github.io/aws-s3-bucket-browser/index.html?bucket=https://s3.amazonaws.com/spacenet-dataset#
MIT License
246 stars 85 forks source link

Dowload files support #49

Closed biegehydra closed 1 month ago

biegehydra commented 1 year ago

Additions

DownloadAll

biegehydra commented 1 year ago

@qoomon Anything need fixed for this to be brought in?

qoomon commented 1 year ago

sorry for the late response, I'll try to review it this weekend

qoomon commented 1 year ago

Hi, thanks for the PR. Some opinion brainstorming:

WDYT?

biegehydra commented 1 year ago
  • I don't think we need the option allowDownload
  • We need to have a progress bar for file downloading status
  • Mabe Download Allshould download really all files including paginated files
  • Maybe we should add checkboxes to mark which files we want to download
  • We should add a dialogue to ensure someone really wants to download X files with a size of Y
  • What about an option to download all files including subdirectories?
  • What about a file count or size limit?

WDYT?

I think they're all good ideas. I'm not that familiar with Vue or Buefy so adding all these features will be difficult for me. I'll take a wack at it when I get the chance though.

Illia-M commented 1 month ago

@qoomon can we update this PR and merge? Really useful for my use cases when people want download folder or all files in folder instead of walking 1000+ files

qoomon commented 1 month ago

@Illia-M Latest version (3.1.0) does support download all files from current page.

@biegehydra thanks a lot for this PR