As of issue #38 / delimeters was encoded to %2F. This was fixed by changing encodeURIComponent to encodeURI. However, this raised an issue of + signs not working in directory names and this was fixed in PR #41 by changing these functions back to the original.
The difference between encodeURI and encodeURIComponent is that ;/?:@&=+$,# are not escaped in encodeURI (ECMA Docs).
On this project encodeURI is not good, as it does not escape characters that could be in file/dir names and S3 does not understand them when they're not escaped.
On the other hand encodeURIComponent is encoding / as well, which works but does not look good when copying the URL of a file.
This PR fixes the issues in these functions by creating a new function encodePath, giving the best of two functions utilizing encodeURI and encoding the missing characters that encodeURIComponent escapes compared to encodeURI.
qoomon
commented
1 year ago
As of issue #38
/delimeters was encoded to%2F. This was fixed by changingencodeURIComponenttoencodeURI. However, this raised an issue of+signs not working in directory names and this was fixed in PR #41 by changing these functions back to the original.The difference between
encodeURIandencodeURIComponentis that;/?:@&=+$,#are not escaped inencodeURI(ECMA Docs).On this project
encodeURIis not good, as it does not escape characters that could be in file/dir names and S3 does not understand them when they're not escaped.On the other hand
encodeURIComponentis encoding/as well, which works but does not look good when copying the URL of a file.This PR fixes the issues in these functions by creating a new function
encodePath, giving the best of two functions utilizingencodeURIand encoding the missing characters thatencodeURIComponentescapes compared toencodeURI.