qoomon / aws-s3-bucket-browser

Single page application to browse AWS S3 bucket content
https://qoomon.github.io/aws-s3-bucket-browser/index.html?bucket=https://s3.amazonaws.com/spacenet-dataset#
MIT License
246 stars 85 forks source link

First efforts for Vue 3 migration #58

Closed ThexXTURBOXx closed 1 month ago

ThexXTURBOXx commented 1 month ago

I am not really versed when it comes to Vue, but this is all I can offer for now. Basic functionality works, but there are a few problems (which I will point out as review comments). Please only merge when you or someone else has fixed these issues!

qoomon commented 1 month ago

thx for your effort

ThexXTURBOXx commented 1 month ago

Thank you very much for finishing this! :) I just have a minor thing to note: Before, my markdown imprint looked like this: grafik

Not, it looks like this: grafik

For some reason, buefy-next does the following: grafik

When disabling these two font-* variables, it looks fine again. Should I report this issue over at buefy-next's repo instead?

qoomon commented 1 month ago

Should I report this issue over at buefy-next's repo instead? Probably yes.

However I'll try to fix it also.

Could your provide me the markdown so i can debug?

ThexXTURBOXx commented 1 month ago

Probably yes. However I'll try to fix it also.

Okay, thank you very much :) If you are not able to fix it, just report back and I will file a bug report over at buefy-next!

Could your provide me the markdown so i can debug?

Don't have it at hand currently, but the following will probably also have the same behaviour and test a few more things on the way:

# Test

This is a _italic_ and **bold** or _**both**_ test.  
And this is `inline code` in a new line.

## Subsection

This should be a subsection.

This is how it should look like:

Test

This is a italic and bold or both test.
And this is inline code in a new line.

Subsection

This should be a subsection.

qoomon commented 1 month ago

@ThexXTURBOXx should be fixed in version 3.0.1

I make use of zero-md again. It renders the markdown in a separate dom so no interference with buefy.

ThexXTURBOXx commented 1 month ago

Thank you very much for your quick actions! :)