search

qoomon / aws-s3-bucket-browser

Single page application to browse AWS S3 bucket content
https://qoomon.github.io/aws-s3-bucket-browser/index.html?bucket=https://s3.amazonaws.com/spacenet-dataset#
MIT License
246 stars 85 forks source link

Fix Android browser search enter #59

Closed ThexXTURBOXx closed 1 month ago

ThexXTURBOXx commented 1 month ago

On Android browsers, currently, one cannot click "enter" to search for the given prefix. This is due to the mobile cards view of the table, which introduces the dropdown menu which in turn allows one to change the order within the table. When pressing "enter" whilst the search bar is focussed, the focus switches to this order dropdown menu instead of searching. To fix this, I set enterkeyhint="search". This even switches the "enter" button on virtual keyboards to a magnifying glass!

Additionally, I switched from @keyup.enter to @keydown.enter, which is also what other big search engines do (such as Google). I think this is somewhat nicer, but I can also revert this particular change if you want :)

ThexXTURBOXx commented 1 month ago

Oops, didn't mean to only draft this PR

qoomon commented 1 month ago

Should be fixed in version 3.0.2

qoomon commented 1 month ago

Thanks for the PR

ThexXTURBOXx commented 1 month ago

You're welcome, and also thank you very much! :)