version.core does not work with ${revision} version

qoomon / maven-git-versioning-extension

This extension will set project version, based on current Git branch or tag.

GNU General Public License v3.0

305 stars 87 forks source link

Open olibraga opened 5 months ago

olibraga commented 5 months ago

If pom contains <version>${revision}</version> and <properties><revision>1.2.r</revision></properties>

the value of ${version.core} is 0.0.0 instead of 1.2.3

qoomon commented 3 months ago

@olibraga why you need to use ${revision} together with this extension?

olibraga commented 2 months ago

It's so a continuous integration system (CircleCI) can set the version to whatever it needs to by overriding the revision property.

qoomon commented 1 month ago

unfortunately that case is not supported. However you could disable versioning by setting environment variable VERSIONING_DISABLE=true or mvn … -Dversioning.disable see https://github.com/qoomon/maven-git-versioning-extension?tab=readme-ov-file#parameters--environment-variables

qoomon commented 1 month ago

Out of curiosity what would be your expected behaviour of this extension? Disable the extension automatically if revision property is set?