search

qooxdoo-archive / qooxdoo-cli

(deprecated, moved into qooxdoo-compiler) qx commandline
MIT License
4 stars 5 forks source link

PR for Issue #12 and Issue #10 #42

Closed hkollmann closed 6 years ago

hkollmann commented 6 years ago

12: if you download a qooxdoo project with a contrib.json file, it should be possible to qx contrib install the libraries contained therein analogous to npm install.

10: to avoid errors like

qx contrib list { Error: ENOENT: no such file or directory, open '/scratch/oetiker/qxtest/compile.json' errno: -2, code: 'ENOENT', syscall: 'open', path: '/scratch/oetiker/qxtest/compile.json' }

during working on #12 it was simple to wrap the calls of getQooxdooPath with an try/catch

cboulanger commented 6 years ago

Cool!

cboulanger commented 6 years ago

Ok, fixed the problems: https://github.com/qooxdoo/qooxdoo-cli/commit/86f43c5d802d391b2a5cd7b98ef468de6be30fac

cboulanger commented 6 years ago

That's why it is important that we create tests! This way, you would have spotted the problems right away...

hkollmann commented 6 years ago

Thanks for fixing! Tests where great!