search

qooxdoo-archive / qooxdoo-cli

(deprecated, moved into qooxdoo-compiler) qx commandline
MIT License
4 stars 5 forks source link

Use acess token again #6

Closed hkollmann closed 7 years ago

hkollmann commented 7 years ago

If you use qx contrib update without an access token you limited to 50 requests. With Access token the limit is 5000.

An undefined token is valid and leads to requests without Access token

cboulanger commented 7 years ago

Typically, you need to do qx contrib update only once per installation, and then again if a new contrib has been published. I understand that the limit could be reached (in case of many contribs or by just repeating use of qx contrib update). However, requiring GitHub tokens looks like a show-stopper to me; then I'd rather change the way information is retrieved from GitHub. For the moment, the PR is fine with me, but I don't think that's the right aproach (having put it in in the first place).

cboulanger commented 7 years ago

If we use the Token, I suggest we put it into an environment variable and get rid of the get/set stuff, I just don't see the need for it any more, it duplicates functionality - we should use compile.json for configuration and not an additional mechanism.

hkollmann commented 7 years ago

The access token is not required - it's optional. So no show stopper. I agree to remove the set/unset stuff. What's about an optional parameter instead of the enviroment variable?

cboulanger commented 7 years ago

Good Idea! (this could still use a env variable via $ if one doesn't like to remember the token)

cboulanger commented 7 years ago

Would you be willing to change your PR to set the auth variable through a parameter instead?

hkollmann commented 7 years ago

I will - after learning to deal with the argv package

hkollmann commented 7 years ago

Done

hkollmann commented 7 years ago

I create a new pull request #7. In this the linefeed are broken.