search

qooxdoo-archive / qooxdoo-cli

(deprecated, moved into qooxdoo-compiler) qx commandline
MIT License
4 stars 5 forks source link

Use new metadata API #60

Closed cboulanger closed 6 years ago

cboulanger commented 6 years ago

@johnspackman Can you review and merge if you approve of the PR?

hkollmann commented 6 years ago

I think we can remove getQoodooVersion instead of deprecate it, could‘nt we?

hkollmann commented 6 years ago

In this case you must change template_vars.js, line 69 too!

cboulanger commented 6 years ago

I tried to remove the method and there was a problem which I did not have the time to investigate - that's why I left it and deprecated it for the time being. I agree with you and will have a second look hopefully later today.

cboulanger commented 6 years ago

@hkollmann @johnspackman Ok, I have reworked it so that now the version number is no longer taken from the versions.txt file but from the Manifest.json (as it should be). For this to work, you need the newest master with @hkollmann's PR that bumped the version numbers (otherwise it the version is still 5.1, which is invalid semver in any case).

cboulanger commented 6 years ago

@johnspackman can you review so that this can get merged? Thanks!