search

qooxdoo / qooxdoo-compiler

Compiler for Qooxdoo, 100% javascript
MIT License
36 stars 23 forks source link

API Change: qx serve <target> instead of qx serve <configFile> #555

Open cboulanger opened 5 years ago

cboulanger commented 5 years ago

I think that very few people actually uses qx serve <configFile>, so we could easily move this use to a parameter such as qx serve --use-config <configFile>. A much more useful syntax would be qx serve <target>, to save typing qx serve --target=<target>.

What do you think?

cboulanger commented 5 years ago

The change could involve some shim which would silently move a file parameter to the correct option.

johnspackman commented 5 years ago

fine by me

hkollmann commented 5 years ago

What‘s about qx compile configFile? It‘s the same syntax. When we change the synrax we should change it consistent. Changing in qx compile break build chains.

Von meinem iPad gesendet

Am 23.08.2019 um 10:43 schrieb John Spackman notifications@github.com:

fine by me

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

cboulanger commented 5 years ago

yes, same thing for qx compile. In order not to break things, the new syntax would silently allow the old by testing if the first non-parameterized argument is the path to a file and move it to the parameter.

hkollmann commented 5 years ago

IMHO we can break things in this state of the project if we anounce it. The change in the build steps are minimal.

Von meinem iPad gesendet

Am 23.08.2019 um 11:24 schrieb Christian Boulanger notifications@github.com:

yes, same thing for qx compile. In order not to break things, the new syntax would silently allow the old by testing if the first non-parameterized argument is the path to a file and move it to the parameter.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.