search

qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 260 forks source link

Font information is not included #10624

Open vinidiktov opened 9 months ago

vinidiktov commented 9 months ago

I've come across a weird issue. If I compile my project with qx version 7.6.1, the Lato font used by the Clean theme is not mentioned in the compiled source code at all.

If, on the other hand, I compile it with 7.5.1, everything works fine.

hkollmann commented 9 months ago

Have you seen the release notes about @. here https://github.com/hkollmann/qooxdoo/blob/master/docs/release-notes.7.0.md ?Von meinem iPhone gesendetAm 16.09.2023 um 17:26 schrieb Alexei Vinidiktov @.>: I've come across a weird issue. If I compile my project with qx version 7.6.1, the Lato font used by the Clean theme is not mentioned in the compiled source code at all. If, on the other hand, I compile it with 7.5.1, everything works fine.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

vinidiktov commented 9 months ago

I’m not sure what to make of it.

hkollmann commented 9 months ago

Add @usefont somewhere to tell the compiler to include font infos

vinidiktov commented 9 months ago

Who should do it: me as the theme’s user or the theme’s author? How is this supposed to work?

johnspackman commented 9 months ago

If this is the same problem that came up on gutter the other week, the issue is that specifying font file names in the theme's Font.js is broken.

The change to font support was supposed to be backward compatible so this is a bug in Qooxdoo rather than something that theme authors should be responsible for changing.

Please can you include an example (eg link to a published theme) that can be used to reproduce this?

vinidiktov commented 9 months ago

This is the theme that I had the issue with: https://github.com/sqville/ville.Clean https://qooxdoo.org/qxl.packagebrowser/#sqville~ville.Clean~library

Please can you include an example (eg link to a published theme) that can be used to reproduce this?

vinidiktov commented 9 months ago

I've just seen this latest commit in the Clean theme's repository: https://github.com/sqville/ville.Clean/commit/7e1b14598cc57b9e19011446221cc9c0ec51867f

It appears to have some fixes related to the updates in font handling in qooxdoo 7.6.

I'm not sure if the theme will remain backwards compatible with qooxdoo < 7.6 after version 1.1 of the theme is released.