Closed p9malino26 closed 4 months ago
Tests has to be parsed!
tests should run:
Assertion error! : Called assert with 'false' Stack trace: qx.core.AssertionError:54:48,qx.Bootstrap:49:24,qx.core.Assert:80:21,qx.core.Assert:123:35,qx.core.MAssert:50:24,qx.test.compiler.ClassFile:61:14 not ok 2 - qx.test.compiler.ClassFile:test issue 633 - [0.43 ms] - : Called assert with 'false' Assertion error! : Called assert with 'false' Stack trace: qx.core.AssertionError:54:48,qx.Bootstrap:49:24,qx.core.Assert:80:21,qx.core.Assert:123:35,qx.core.MAssert:50:24,qx.test.compiler.ClassFile:75:14 not ok 4 - qx.test.compiler.ClassFile:test issue 524 - [1.38 ms] - Error in asynchronous test: resume() called before wait() Assertion error! : Called assert with 'false' Stack trace: qx.core.AssertionError:54:48,qx.Bootstrap:49:24,qx.core.Assert:80:21,qx.core.Assert:123:35,qx.core.MAssert:50:24,qx.test.compiler.ClassFile:82:14 not ok 8 - qx.test.compiler.ClassFile:test issue 726 - [0.21 ms] - : Called assert with 'false'
@pmalinowski-vmn it would be great if you could make your change such that the tests will run, as this also goes a long way towards avoiding backward compatibility issues
Sorry for the long reply; was on a break.
I will fix the code so the tests pass.
Just a note that this PR will need to be reimplemented in the new class/property system if/when that PR is merged.
This is a cool addition, thanks alot - @p9malino26 it would be great if you could write something for https://news.qooxdoo.org/ on it. BTW - @johnspackman I think you/your company also added some features that should be covered. the good thing is that you can just reuse parts of the docs for a blog post.
@cboulanger good idea - we'll get onto it in the next week 👍
I've written a draft of the blog post: https://medium.com/@pmalinowski/new-feature-top-level-objects-section-63dab192d7e0
Not sure if I have the privileges to publish it on the Qooxdoo channel though.
@p9malino26 I will gladly give you these ... please tell me your medium username
@pmalinowski
Thanks a lot
done
This PR implements the proposal in issue #10641 (a better way of defining objects referenced by getQxObject)