search

qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 259 forks source link

Optional `requires` in Manifest #10651

Closed WillsterJohnsonAtZenesis closed 3 months ago

WillsterJohnsonAtZenesis commented 3 months ago 
+     if (!manifest.requires) {
+       return false;
+     }
      for (let lib_uri of Object.getOwnPropertyNames(manifest.requires)) {

If the argument to Object.getOwnPropertyNames is not an object (including if it's null), then a TypeError is thrown. This guard statement prevents the issue from occurring.