qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 259 forks source link

qx.locale.String methods #10661

Closed goldim closed 2 months ago

goldim commented 2 months ago

The methods of the class don't work and don't return what expected. Also they are not used in qooxdoo framework code at all. I doubt they are used in users' apps too. There are no tests for these methods too. Maybe to remove them?

Playground.

qooxdoo version is 7.6.3.

johnspackman commented 2 months ago

wow - yes, i think that we should remove them

derrell commented 2 months ago

Although we might suspect it's not used by users, it is a non-BC change and we don't know for sure that it's not being used, so I believe it should come with the next major version number update.

goldim commented 2 months ago

Unfortunately It is BC anyway. I want to check how it worked in 5 and 6 version bc there were changes in 7.

cboulanger commented 2 months ago

I'd say, remove it completely for v8 as part of getting rid of the huge cldr dependency - very much appreciated!

goldim commented 2 months ago

@derrell they don't work in qooxdoo version 6. I will check 5 soon.

johnspackman commented 2 months ago

My guess is that it works with the generator and not with the compiler...

goldim commented 2 months ago

@johnspackman the same in 5 version: doesn't work properly. The output of console.log(qx.locale.String.getAlternateQuotationEnd("en_GB"));:

{
    "__txt": "cldr_alternateQuotationEnd",
    "length": 26,
    "__messageId": "cldr_alternateQuotationEnd",
    "__args": [],
    "$$initialized": true
}
johnspackman commented 2 months ago

@goldim nice to know it wasnt me :)