qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 259 forks source link

(a very small) fix: qx.tool.utils.Utils.formatTime s/m/H trimming #10667

Closed WillsterJohnsonAtZenesis closed 2 months ago

WillsterJohnsonAtZenesis commented 2 months ago

I've noticed that when compiling a lot of classes (eg, enough that it takes longer than 60s to compile) the duration in the message is a little odd.

For example, earlier when clean compiling qooxdoo, the compilation took around 143s to complete - that's 2m 23s, right?

>>> Compiled 1451 classes in 02m 143.532s

According to that message though it seems to say that it took 2 mins plus 143 secs.

It turns out that seconds/minutes which should have been counted only for a larger minute/hour were also being counted for the seconds/minutes themselves.

I added this commit, clean compiled again, this time the compilation took a little longer, around 147s - 2m 27s.

>>> Compiled 1451 classes in 02m 27.667s

That's much better, the seconds which make up those 2 mins are no longer being counted in the seconds value.