search

qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 259 forks source link

fixes a bug where `qx.html.Image` breaks JSX #10680

Closed johnspackman closed 1 month ago

johnspackman commented 1 month ago

fixes a bug where qx.html.Image is only suitable for qx.ui.basic.Image and should not be part of the JSX / VDOM because it breaks the <img> tag

johnspackman commented 1 month ago

WRT to the formatting issue - prettier keeps breaking things. I think i've caught them all and put them back, and included turning off the commit hook that was causing it to happen every commit 🙄

goldim commented 1 month ago

@johnspackman should this hook be uncommented now after changes?

johnspackman commented 1 month ago

@johnspackman should this hook be uncommented now after changes?

just been trying to make a PR to fix this, but it turns out that it is down to babel mangling the tree before prettier gets involved - and unfortunately, prettier isn't able to fix it.

This means that es6ify should not be used routinely on commits - but prettier should. I've fixed it, although it won't work on Windows unless there is a bash