search

qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 259 forks source link

adds a `privateArtifacts` option to `compile.json` #10681

Closed johnspackman closed 1 month ago

johnspackman commented 1 month ago

This adds a privateArtifacts option to compile.json to allow all urls to be locked within an application directory

goldim commented 1 month ago

@johnspackman I can't compile your PR bc the compiler complains on new option. Has this to be updated https://qooxdoo.org/schema/compile-1-0-0.json ? I removed schema attribute from compile.json to suppress error but after compiling with option nothing changed: all files on the same with app folder in target folder.

johnspackman commented 1 month ago

Has this to be updated https://qooxdoo.org/schema/compile-1-0-0.json

Yes, I think that gets updated automatically when we do a release, but until then you'll get errors

after compiling with option nothing changed: all files on the same with app folder in target folder.

It is intentional that the files are still in the same place - but if you look at your generated myappname/index.js you'll see that the path to the files (resources and transpiled directories) has changed; the intention of this change is to allow you to have a URL on your web server where you only expose (or set permissions for) the application directory, and you would need to mount virtual folders within that URL.

EG in order to have an application at the root (eg http://www.mywebsite.com/, the transpiled and resource directory cannot be in ../transpiled

Where there are multiple apps in a build, the resource and transpiled directories on disk need to be shared, hence the need to add virtual folders.