qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
764 stars 260 forks source link

qx.bom.Input - missing input types #10703

Open WillsterJohnson opened 1 week ago

WillsterJohnson commented 1 week ago

Describe the bug According to mdn, there are 22 valid input types, however qx.bom.Input only supports 13, of which 2 are not valid input types (textarea and select are their own html elements distinct from <input>).

To Reproduce Steps to reproduce the behavior:

<input type="number" />; // or any other missing type

Expected behavior An instance of qx.html.Element with tagName="input" and attributes={type:"number"} should be created via qx.html.Jsx.createElement

Screenshots Screenshot

Desktop (please complete the following information):

Additional context This issue makes it impossible to use half of the available input types in jsx, importantly the number type.

Proposed Solution:

This would only change the behavior of code which would otherwise throw an error and crash the application, so is shouldn't have any impact on existing code.

goldim commented 1 week ago

@WillsterJohnson I also don't see any problem just adding the support for new types. As you said old apps will work as before and if they use new types they get some crash. Maybe there are ways to handle an error. Could you provide a PR please?