Property "selectable" has no effect on Labels (BZ#2913)

[qx-bug-importer]

Matthias Hellriegel (Matthias.Hellriegel) wrote:

Following code does not work as expected (the label could not be selected):

var label = new qx.ui.basic.Label("test").set({ selectable : true });

assigned to Jonathan Weiß (qooxdoo-bugs)

[qx-bug-importer]

Andreas Ecker (@ecker) wrote:

Fabian, to you as discussed

[qx-bug-importer]

Fabian Jakobs (@fjakobs) wrote:

to jonny

[qx-bug-importer]

Sebastian Werner (@swernerx) wrote:

I would suggest to overwrite the _applySelectable method and throw an exception for labels. The issue here is that selection=true and ellipse support will not work with the current support in Firefox.

[qx-bug-importer]

Sebastian Werner (@swernerx) wrote:

Just another though: Basically one never would select a Label as labels are to describe other elements. If one would have a selectable text, it should be the case that all text is seen (no ellipsis). One might offer a separate widget for such use-cases e.g. a TextView like in Android... or just use the HTML embed widget.

[qx-bug-importer]

Jonathan Weiß (qooxdoo-bugs) wrote:

Accepted.

[qx-bug-importer]

Jonathan Weiß (qooxdoo-bugs) wrote:

Fixed in trunk (r20430).

Reference to Mozilla Bugzilla entry: https://bugzilla.mozilla.org/show_bug.cgi?id=312156

[qx-bug-importer]

Sebastian Werner (@swernerx) wrote:

That would be a helpful comment here as well, not just in SVN :)

"We decided to warn the user when he tries to set a label selectable in gecko-based browsers."

[qx-bug-importer]

Sebastian Werner (@swernerx) wrote:

Wouldn't it be better to put the debug warning into a debug variant? Just for keeping overhead minimal in deployed apps?

Also it might be useful to display the warning in non-geckos as well. One might develop in Safari all the time and so never see this warning until testing in Firefox.

Just my 2 cents ;)

[qx-bug-importer]

Andreas Ecker (@ecker) wrote:

mass renaming of 0.9 target to 1.0-beta1

[qx-bug-importer]

Tristan Koch (@trkoch) wrote:

* BZ#4613 has been marked as a duplicate of this bug. *

[qx-bug-importer]

Martin Wittemann (@wittemann) wrote:

Closed all bugs already shipped with a release.