search

qooxdoo / qooxdoo

qooxdoo - Universal JavaScript Framework
http://qooxdoo.org
Other
766 stars 261 forks source link

Generator warnings in spite of #ignore tag (BZ#7044) #7088

Closed qx-bug-importer closed 8 years ago

qx-bug-importer commented 11 years ago

saaj (id) wrote:

Particularly, I use uploadmgr (http://qooxdoo.org/contrib/project/uploadmgr). So updating to qx2.1 I have the following warnings on a first build.

XhrHandler.js has two #ignore tags:

ignore(File)

ignore(FormData)

so it's a little strange that warnings are related to FormData only, as File global is referenced as well.

Further builds doesn't raise the warning because of cache. Also there was no such issue in 2.0.1.

assigned to Thomas Herchenroeder (@thron7)

qx-bug-importer commented 11 years ago

saaj (id) wrote:

That happens with application code as well, so I renamed the bug.

qx-bug-importer commented 11 years ago

Deacon (dfrost999) wrote:

This is open for 2 month. For me it renders 2.1 almost useless because it blows up my CI builds with warnings. It is difficult enough to make generator behave quietly (spinning bars etc.), now it even complains about jsdoc strings it cannot parse! For bigger projects this stuff needs to run in automated build environments where warnings have to be treated as errors so every additional output of the tool has to be dealt with. It is very difficult to integrate the qx-toolchain with external libraries as is (works with lots of fiddling in source or hybrid mode, but then blows up in build mode class loader) though IMHO this gets more and more important in JS-land so at least make it ignore external stuff. Please expedite this...

qx-bug-importer commented 11 years ago

Thomas Herchenroeder (@thron7) wrote:

Deacon,

ignore hints are still honored by the dependency analysis. But with the new warning system (see bug#4561), I wouldn't want to introduce too much compatibility code when the old #-hints will be deprecated in one of the next versions anyway.

> This is open for 2 month. For me it renders 2.1 almost useless because it blows > up my CI builds with warnings.

Even if we were to fix it, you would need to wait for at least the next patch release (2.1.1) which hasn't even been scheduled.

> It is difficult enough to make generator behave quietly (spinning bars etc.), > now it even complains about jsdoc strings it cannot parse!

Yes, it's a constant struggle between these two needs - making the generator warnings more precise for more consistency, and making them quiet.

> For bigger projects this stuff needs to run in automated build environments > where warnings have to be treated as errors so every additional output of the > tool has to be dealt with.

We're aware of automated build environments, we are using them ourself. But I don't see how you are not able to ignore warnings on that level. At the very least you can ignore all of them, as long as the generator terminates with a zero status code.

> It is very difficult to integrate the qx-toolchain with external libraries as > is (works with lots of fiddling in source or hybrid mode, but then blows up in > build mode class loader)

I don't get this ...?!

> though IMHO this gets more and more important in > JS-land so at least make it ignore external stuff. > Please expedite this...

I just checked the UploadMgr contrib, and John Spackman, the maintainer, has turned all #ignore's into new-style ignore's. If you upgrade to the latest UploadMgr you should be all set.

qx-bug-importer commented 11 years ago

saaj (id) wrote:

To disable "spinning bar" it's enough to run generator with -I flag which disables progress animation.

About ignore tag:

So as you can see in its sources, qx currently uses both ignore and #ignore. Some files have only one syntax, some both. As of 2.1 only the former works in user code... here I see the email notification that Thomas already replied so I stop on this ;-)

qx-bug-importer commented 11 years ago

saaj (id) wrote:

I'll add about external libraries. In its codebase qooxdoo itself has examples of external libraries management. E.g. https://github.com/qooxdoo/qooxdoo/blob/master/framework/source/class/qx/bom/Template.js. And it was working pretty good so far.

qx-bug-importer commented 11 years ago

Deacon (dfrost999) wrote:

Thanks a lot for your input! I added ignore tags to the code and that seems to work. I was not aware of this.

Sorry if my comment came across as harsh. My point was that I am of course grateful for warnings (the more and detailed the better) but if they are not "real" warnings and cannot be suppressed either it interferes with the build process (which should treat warnings as errors) or makes you ignore them altogether which of course defeats their purpose.

qx-bug-importer commented 11 years ago

Thomas Herchenroeder (@thron7) wrote:

So I hope everybody is fine with closing this bug.

qx-bug-importer commented 10 years ago

Martin Wittemann (@wittemann) wrote:

Closed all bugs already shipped with a release.