search

qooxdoo / qxl.apiviewer

qooxdoo apiviewer app
https://qooxdoo.org/qxl.apiviewer
MIT License
5 stars 5 forks source link

Fixes #36 and #37 #39

Closed cboulanger closed 4 years ago

hkollmann commented 4 years ago

It‘s just to be save.

Von meinem iPhone gesendet

Am 25.06.2020 um 17:49 schrieb Christian Boulanger notifications@github.com:

 @cboulanger commented on this pull request.

In compile.js:

     qxl.apiviewer.ClassLoader.setBaseUri(path.join(target.getOutputDir(), "transpiled") + path.sep);

let env = environment;

  • let excludeFromAPIViewer = env.excludeFromAPIViewer;
  • let includeToAPIViewer = env.includeToAPIViewer;
  • let excludeFromAPIViewer = env.excludeFromAPIViewer || env["qxl.apiviewer.exclude"];
  • let includeToAPIViewer = env.includeToAPIViewer || env["qxl.apiviewer.include"]; But do you think anyone will have both values in their compile.json - this is just for BC reasons for the existing apps, once they are updated, I would remove env.excludeFromAPIViewer ||`entirely. If anything, we could add a deprecation warning that copies excludeFromAPIViewer to the new property.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.