search

qooxdoo / website

The source code for building Qooxdoo's website
http://qooxdoo.org
3 stars 7 forks source link

fix links to documentation #14

Closed hkollmann closed 4 years ago

github-actions[bot] commented 4 years ago

The website in the version of this PR has been published at http://qooxdoo.org/website/PR_14

cboulanger commented 4 years ago

In principle, there is no need to change this, /docs/ should continue to work, if not, the script in 404.html is not yet updated...

cboulanger commented 4 years ago

On the other hand, it doesn't hurt to change it.

hkollmann commented 4 years ago

Keep it simple and use the direct link. Works without 404.html magic. That's why i changed it.

hkollmann commented 4 years ago

Hey the preview feature is great!!!!

cboulanger commented 4 years ago

I now remember why it's important not to change the apps:// pseudo-protocol - the documentation must work online and offline (i.e. on the website and in the qx serve application server). The links to the apps will be resolved differently in both cases, so that's why that magic needs to stay. Also, it will ensure that the markdown URL-linter will not check these links.

cboulanger commented 4 years ago

Yes, I like that, too, including the bot comment. Powered by GitHub actions. Very cool.

hkollmann commented 4 years ago

But that's a documentation issue - not a website issue.

cboulanger commented 4 years ago

Oh you're right. Wrong issue.